<html>
<head><meta charset="utf-8"><title>Add a `NOOP_METHOD_CALL` lint for methods… compiler-team#375 · t-compiler/major changes · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/233931-t-compiler/major-changes/index.html">t-compiler/major changes</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/233931-t-compiler/major-changes/topic/Add.20a.20.60NOOP_METHOD_CALL.60.20lint.20for.20methods.E2.80.A6.20compiler-team.23375.html">Add a `NOOP_METHOD_CALL` lint for methods… compiler-team#375</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="214128383"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/233931-t-compiler/major%20changes/topic/Add%20a%20%60NOOP_METHOD_CALL%60%20lint%20for%20methods%E2%80%A6%20compiler-team%23375/near/214128383" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> triagebot <a href="https://rust-lang.github.io/zulip_archive/stream/233931-t-compiler/major-changes/topic/Add.20a.20.60NOOP_METHOD_CALL.60.20lint.20for.20methods.E2.80.A6.20compiler-team.23375.html#214128383">(Oct 21 2020 at 23:43)</a>:</h4>
<p>A new proposal has been announced: <a href="https://github.com/rust-lang/compiler-team/issues/375">Add a <code>NOOP_METHOD_CALL</code> lint for methods which should never be directly called #375</a>. It will be announced at the next meeting to try and draw attention to it, but usually MCPs are not discussed during triage meetings. If you think this would benefit from discussion amongst the team, consider proposing a design meeting.</p>



<a name="214128459"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/233931-t-compiler/major%20changes/topic/Add%20a%20%60NOOP_METHOD_CALL%60%20lint%20for%20methods%E2%80%A6%20compiler-team%23375/near/214128459" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/233931-t-compiler/major-changes/topic/Add.20a.20.60NOOP_METHOD_CALL.60.20lint.20for.20methods.E2.80.A6.20compiler-team.23375.html#214128459">(Oct 21 2020 at 23:44)</a>:</h4>
<p>is there an existing clippy lint for this?</p>



<a name="214129060"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/233931-t-compiler/major%20changes/topic/Add%20a%20%60NOOP_METHOD_CALL%60%20lint%20for%20methods%E2%80%A6%20compiler-team%23375/near/214129060" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aaron Hill <a href="https://rust-lang.github.io/zulip_archive/stream/233931-t-compiler/major-changes/topic/Add.20a.20.60NOOP_METHOD_CALL.60.20lint.20for.20methods.E2.80.A6.20compiler-team.23375.html#214129060">(Oct 21 2020 at 23:53)</a>:</h4>
<p>let me check</p>



<a name="214129066"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/233931-t-compiler/major%20changes/topic/Add%20a%20%60NOOP_METHOD_CALL%60%20lint%20for%20methods%E2%80%A6%20compiler-team%23375/near/214129066" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aaron Hill <a href="https://rust-lang.github.io/zulip_archive/stream/233931-t-compiler/major-changes/topic/Add.20a.20.60NOOP_METHOD_CALL.60.20lint.20for.20methods.E2.80.A6.20compiler-team.23375.html#214129066">(Oct 21 2020 at 23:53)</a>:</h4>
<p>if so, I think we should uplift it</p>



<a name="214129173"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/233931-t-compiler/major%20changes/topic/Add%20a%20%60NOOP_METHOD_CALL%60%20lint%20for%20methods%E2%80%A6%20compiler-team%23375/near/214129173" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aaron Hill <a href="https://rust-lang.github.io/zulip_archive/stream/233931-t-compiler/major-changes/topic/Add.20a.20.60NOOP_METHOD_CALL.60.20lint.20for.20methods.E2.80.A6.20compiler-team.23375.html#214129173">(Oct 21 2020 at 23:54)</a>:</h4>
<p>there's a <code>clone_double_ref</code> for <code>clone</code> specifically</p>



<a name="214129194"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/233931-t-compiler/major%20changes/topic/Add%20a%20%60NOOP_METHOD_CALL%60%20lint%20for%20methods%E2%80%A6%20compiler-team%23375/near/214129194" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aaron Hill <a href="https://rust-lang.github.io/zulip_archive/stream/233931-t-compiler/major-changes/topic/Add.20a.20.60NOOP_METHOD_CALL.60.20lint.20for.20methods.E2.80.A6.20compiler-team.23375.html#214129194">(Oct 21 2020 at 23:55)</a>:</h4>
<p>but there's no generic lint that covers other noop methods on <code>&amp;T</code></p>



<a name="214129217"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/233931-t-compiler/major%20changes/topic/Add%20a%20%60NOOP_METHOD_CALL%60%20lint%20for%20methods%E2%80%A6%20compiler-team%23375/near/214129217" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aaron Hill <a href="https://rust-lang.github.io/zulip_archive/stream/233931-t-compiler/major-changes/topic/Add.20a.20.60NOOP_METHOD_CALL.60.20lint.20for.20methods.E2.80.A6.20compiler-team.23375.html#214129217">(Oct 21 2020 at 23:55)</a>:</h4>
<p>so, I think we could remove the clippy one if we add the rustc one</p>



<a name="214129282"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/233931-t-compiler/major%20changes/topic/Add%20a%20%60NOOP_METHOD_CALL%60%20lint%20for%20methods%E2%80%A6%20compiler-team%23375/near/214129282" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/233931-t-compiler/major-changes/topic/Add.20a.20.60NOOP_METHOD_CALL.60.20lint.20for.20methods.E2.80.A6.20compiler-team.23375.html#214129282">(Oct 21 2020 at 23:56)</a>:</h4>
<p>the general case sounds hard to do - would there be a fixed list of no-ops? Or would the lint look for functions implemented as the identity function?</p>



<a name="214129325"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/233931-t-compiler/major%20changes/topic/Add%20a%20%60NOOP_METHOD_CALL%60%20lint%20for%20methods%E2%80%A6%20compiler-team%23375/near/214129325" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aaron Hill <a href="https://rust-lang.github.io/zulip_archive/stream/233931-t-compiler/major-changes/topic/Add.20a.20.60NOOP_METHOD_CALL.60.20lint.20for.20methods.E2.80.A6.20compiler-team.23375.html#214129325">(Oct 21 2020 at 23:56)</a>:</h4>
<p>I don't think we'd want to do any autodetection</p>



<a name="214129338"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/233931-t-compiler/major%20changes/topic/Add%20a%20%60NOOP_METHOD_CALL%60%20lint%20for%20methods%E2%80%A6%20compiler-team%23375/near/214129338" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aaron Hill <a href="https://rust-lang.github.io/zulip_archive/stream/233931-t-compiler/major-changes/topic/Add.20a.20.60NOOP_METHOD_CALL.60.20lint.20for.20methods.E2.80.A6.20compiler-team.23375.html#214129338">(Oct 21 2020 at 23:56)</a>:</h4>
<p>I proposed a <code>#[noop]</code> attribute in the MCP</p>



<a name="214129350"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/233931-t-compiler/major%20changes/topic/Add%20a%20%60NOOP_METHOD_CALL%60%20lint%20for%20methods%E2%80%A6%20compiler-team%23375/near/214129350" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aaron Hill <a href="https://rust-lang.github.io/zulip_archive/stream/233931-t-compiler/major-changes/topic/Add.20a.20.60NOOP_METHOD_CALL.60.20lint.20for.20methods.E2.80.A6.20compiler-team.23375.html#214129350">(Oct 21 2020 at 23:57)</a>:</h4>
<p>though that doens't cover all of the cases in libstd</p>



<a name="214129407"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/233931-t-compiler/major%20changes/topic/Add%20a%20%60NOOP_METHOD_CALL%60%20lint%20for%20methods%E2%80%A6%20compiler-team%23375/near/214129407" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aaron Hill <a href="https://rust-lang.github.io/zulip_archive/stream/233931-t-compiler/major-changes/topic/Add.20a.20.60NOOP_METHOD_CALL.60.20lint.20for.20methods.E2.80.A6.20compiler-team.23375.html#214129407">(Oct 21 2020 at 23:57)</a>:</h4>
<p>all of the methods I listed in the MCP are essentially the same (and any known calls to them can be removed), so I think it makes sense to have a single lint for all of them</p>



<a name="214133191"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/233931-t-compiler/major%20changes/topic/Add%20a%20%60NOOP_METHOD_CALL%60%20lint%20for%20methods%E2%80%A6%20compiler-team%23375/near/214133191" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> scottmcm <a href="https://rust-lang.github.io/zulip_archive/stream/233931-t-compiler/major-changes/topic/Add.20a.20.60NOOP_METHOD_CALL.60.20lint.20for.20methods.E2.80.A6.20compiler-team.23375.html#214133191">(Oct 22 2020 at 00:58)</a>:</h4>
<p>conceptually: <span aria-label="+1" class="emoji emoji-1f44d" role="img" title="+1">:+1:</span></p>



<a name="214133195"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/233931-t-compiler/major%20changes/topic/Add%20a%20%60NOOP_METHOD_CALL%60%20lint%20for%20methods%E2%80%A6%20compiler-team%23375/near/214133195" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> scottmcm <a href="https://rust-lang.github.io/zulip_archive/stream/233931-t-compiler/major-changes/topic/Add.20a.20.60NOOP_METHOD_CALL.60.20lint.20for.20methods.E2.80.A6.20compiler-team.23375.html#214133195">(Oct 22 2020 at 00:58)</a>:</h4>
<p><span aria-label="bike" class="emoji emoji-1f6b2" role="img" title="bike">:bike:</span><span aria-label="derelict house" class="emoji emoji-1f3da" role="img" title="derelict house">:derelict_house:</span>: <code>noop</code> doesn't really seem right for this to me.  <code>Clone::clone(&amp;true)</code> is silly, but not exactly a no-op.</p>



<a name="214133232"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/233931-t-compiler/major%20changes/topic/Add%20a%20%60NOOP_METHOD_CALL%60%20lint%20for%20methods%E2%80%A6%20compiler-team%23375/near/214133232" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> scottmcm <a href="https://rust-lang.github.io/zulip_archive/stream/233931-t-compiler/major-changes/topic/Add.20a.20.60NOOP_METHOD_CALL.60.20lint.20for.20methods.E2.80.A6.20compiler-team.23375.html#214133232">(Oct 22 2020 at 00:59)</a>:</h4>
<p>Trouble for the attribute: there's no specific <code>&lt;&amp;T as ToOwned&gt;::to_owned</code> today.  That comes from the blanket <code>ToOwned</code> for <code>Clone</code> types.</p>



<a name="214140747"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/233931-t-compiler/major%20changes/topic/Add%20a%20%60NOOP_METHOD_CALL%60%20lint%20for%20methods%E2%80%A6%20compiler-team%23375/near/214140747" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aaron Hill <a href="https://rust-lang.github.io/zulip_archive/stream/233931-t-compiler/major-changes/topic/Add.20a.20.60NOOP_METHOD_CALL.60.20lint.20for.20methods.E2.80.A6.20compiler-team.23375.html#214140747">(Oct 22 2020 at 03:43)</a>:</h4>
<p>Yeah - I discussed a couple of approaches to solving that in the mcp</p>



<a name="214140807"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/233931-t-compiler/major%20changes/topic/Add%20a%20%60NOOP_METHOD_CALL%60%20lint%20for%20methods%E2%80%A6%20compiler-team%23375/near/214140807" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aaron Hill <a href="https://rust-lang.github.io/zulip_archive/stream/233931-t-compiler/major-changes/topic/Add.20a.20.60NOOP_METHOD_CALL.60.20lint.20for.20methods.E2.80.A6.20compiler-team.23375.html#214140807">(Oct 22 2020 at 03:45)</a>:</h4>
<p>If we start out by just linting std types, we don't have to commit ourselves to any particular way of marking the method</p>



<a name="214140811"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/233931-t-compiler/major%20changes/topic/Add%20a%20%60NOOP_METHOD_CALL%60%20lint%20for%20methods%E2%80%A6%20compiler-team%23375/near/214140811" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aaron Hill <a href="https://rust-lang.github.io/zulip_archive/stream/233931-t-compiler/major-changes/topic/Add.20a.20.60NOOP_METHOD_CALL.60.20lint.20for.20methods.E2.80.A6.20compiler-team.23375.html#214140811">(Oct 22 2020 at 03:45)</a>:</h4>
<p>Also, I'm find with calling the attr something other than <code>noop</code> - it was the first thing that came to mind</p>



<a name="214868673"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/233931-t-compiler/major%20changes/topic/Add%20a%20%60NOOP_METHOD_CALL%60%20lint%20for%20methods%E2%80%A6%20compiler-team%23375/near/214868673" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aaron Hill <a href="https://rust-lang.github.io/zulip_archive/stream/233931-t-compiler/major-changes/topic/Add.20a.20.60NOOP_METHOD_CALL.60.20lint.20for.20methods.E2.80.A6.20compiler-team.23375.html#214868673">(Oct 28 2020 at 17:14)</a>:</h4>
<p>There hasn't been any discussion of this for a week. Is anyone opposed to the overall concept of the lint (leaving aside the exact name and attributefor the moment)?</p>



<a name="214868788"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/233931-t-compiler/major%20changes/topic/Add%20a%20%60NOOP_METHOD_CALL%60%20lint%20for%20methods%E2%80%A6%20compiler-team%23375/near/214868788" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/233931-t-compiler/major-changes/topic/Add.20a.20.60NOOP_METHOD_CALL.60.20lint.20for.20methods.E2.80.A6.20compiler-team.23375.html#214868788">(Oct 28 2020 at 17:15)</a>:</h4>
<p>SGTM, but I'm still a little unclear exactly how it will be implemented. I guess that doesn't need to block the MCP though.</p>



<a name="214989028"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/233931-t-compiler/major%20changes/topic/Add%20a%20%60NOOP_METHOD_CALL%60%20lint%20for%20methods%E2%80%A6%20compiler-team%23375/near/214989028" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aaron Hill <a href="https://rust-lang.github.io/zulip_archive/stream/233931-t-compiler/major-changes/topic/Add.20a.20.60NOOP_METHOD_CALL.60.20lint.20for.20methods.E2.80.A6.20compiler-team.23375.html#214989028">(Oct 29 2020 at 16:05)</a>:</h4>
<p>Since this is a new lint, does this require a T-Lang FCP?</p>



<a name="215034971"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/233931-t-compiler/major%20changes/topic/Add%20a%20%60NOOP_METHOD_CALL%60%20lint%20for%20methods%E2%80%A6%20compiler-team%23375/near/215034971" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/233931-t-compiler/major-changes/topic/Add.20a.20.60NOOP_METHOD_CALL.60.20lint.20for.20methods.E2.80.A6.20compiler-team.23375.html#215034971">(Oct 29 2020 at 22:10)</a>:</h4>
<p><span class="user-mention" data-user-id="125294">@Aaron Hill</span> usually we FCP the PR</p>



<a name="215035013"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/233931-t-compiler/major%20changes/topic/Add%20a%20%60NOOP_METHOD_CALL%60%20lint%20for%20methods%E2%80%A6%20compiler-team%23375/near/215035013" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/233931-t-compiler/major-changes/topic/Add.20a.20.60NOOP_METHOD_CALL.60.20lint.20for.20methods.E2.80.A6.20compiler-team.23375.html#215035013">(Oct 29 2020 at 22:10)</a>:</h4>
<p>but you could FCP before-hand too</p>



<a name="215035232"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/233931-t-compiler/major%20changes/topic/Add%20a%20%60NOOP_METHOD_CALL%60%20lint%20for%20methods%E2%80%A6%20compiler-team%23375/near/215035232" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aaron Hill <a href="https://rust-lang.github.io/zulip_archive/stream/233931-t-compiler/major-changes/topic/Add.20a.20.60NOOP_METHOD_CALL.60.20lint.20for.20methods.E2.80.A6.20compiler-team.23375.html#215035232">(Oct 29 2020 at 22:13)</a>:</h4>
<p>Does that happen before or after it's seconded?</p>



<a name="215035883"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/233931-t-compiler/major%20changes/topic/Add%20a%20%60NOOP_METHOD_CALL%60%20lint%20for%20methods%E2%80%A6%20compiler-team%23375/near/215035883" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/233931-t-compiler/major-changes/topic/Add.20a.20.60NOOP_METHOD_CALL.60.20lint.20for.20methods.E2.80.A6.20compiler-team.23375.html#215035883">(Oct 29 2020 at 22:20)</a>:</h4>
<p>so I'm not sure if my script will pick up MCP changes for t-lang :)</p>



<a name="215035886"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/233931-t-compiler/major%20changes/topic/Add%20a%20%60NOOP_METHOD_CALL%60%20lint%20for%20methods%E2%80%A6%20compiler-team%23375/near/215035886" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/233931-t-compiler/major-changes/topic/Add.20a.20.60NOOP_METHOD_CALL.60.20lint.20for.20methods.E2.80.A6.20compiler-team.23375.html#215035886">(Oct 29 2020 at 22:20)</a>:</h4>
<p>you could file an issue and nominate it for now</p>



<a name="215035892"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/233931-t-compiler/major%20changes/topic/Add%20a%20%60NOOP_METHOD_CALL%60%20lint%20for%20methods%E2%80%A6%20compiler-team%23375/near/215035892" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/233931-t-compiler/major-changes/topic/Add.20a.20.60NOOP_METHOD_CALL.60.20lint.20for.20methods.E2.80.A6.20compiler-team.23375.html#215035892">(Oct 29 2020 at 22:20)</a>:</h4>
<p>we should tweak these procedures</p>



<a name="215035911"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/233931-t-compiler/major%20changes/topic/Add%20a%20%60NOOP_METHOD_CALL%60%20lint%20for%20methods%E2%80%A6%20compiler-team%23375/near/215035911" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/233931-t-compiler/major-changes/topic/Add.20a.20.60NOOP_METHOD_CALL.60.20lint.20for.20methods.E2.80.A6.20compiler-team.23375.html#215035911">(Oct 29 2020 at 22:21)</a>:</h4>
<p>(been on my mind to try and harmonize things a bit...)</p>



<a name="215035919"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/233931-t-compiler/major%20changes/topic/Add%20a%20%60NOOP_METHOD_CALL%60%20lint%20for%20methods%E2%80%A6%20compiler-team%23375/near/215035919" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/233931-t-compiler/major-changes/topic/Add.20a.20.60NOOP_METHOD_CALL.60.20lint.20for.20methods.E2.80.A6.20compiler-team.23375.html#215035919">(Oct 29 2020 at 22:21)</a>:</h4>
<p>alternatively file a lang-team proposal :)</p>



<a name="215035924"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/233931-t-compiler/major%20changes/topic/Add%20a%20%60NOOP_METHOD_CALL%60%20lint%20for%20methods%E2%80%A6%20compiler-team%23375/near/215035924" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/233931-t-compiler/major-changes/topic/Add.20a.20.60NOOP_METHOD_CALL.60.20lint.20for.20methods.E2.80.A6.20compiler-team.23375.html#215035924">(Oct 29 2020 at 22:21)</a>:</h4>
<p>any which way to get it on the triage meeting agenda</p>



<a name="215035937"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/233931-t-compiler/major%20changes/topic/Add%20a%20%60NOOP_METHOD_CALL%60%20lint%20for%20methods%E2%80%A6%20compiler-team%23375/near/215035937" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/233931-t-compiler/major-changes/topic/Add.20a.20.60NOOP_METHOD_CALL.60.20lint.20for.20methods.E2.80.A6.20compiler-team.23375.html#215035937">(Oct 29 2020 at 22:21)</a>:</h4>
<p>(gotta run now)</p>



<a name="215035952"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/233931-t-compiler/major%20changes/topic/Add%20a%20%60NOOP_METHOD_CALL%60%20lint%20for%20methods%E2%80%A6%20compiler-team%23375/near/215035952" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/233931-t-compiler/major-changes/topic/Add.20a.20.60NOOP_METHOD_CALL.60.20lint.20for.20methods.E2.80.A6.20compiler-team.23375.html#215035952">(Oct 29 2020 at 22:21)</a>:</h4>
<p>I'm presuming you want lang team input <em>before</em> you implement</p>



<a name="215136240"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/233931-t-compiler/major%20changes/topic/Add%20a%20%60NOOP_METHOD_CALL%60%20lint%20for%20methods%E2%80%A6%20compiler-team%23375/near/215136240" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aaron Hill <a href="https://rust-lang.github.io/zulip_archive/stream/233931-t-compiler/major-changes/topic/Add.20a.20.60NOOP_METHOD_CALL.60.20lint.20for.20methods.E2.80.A6.20compiler-team.23375.html#215136240">(Oct 30 2020 at 18:52)</a>:</h4>
<p>Opened <a href="https://github.com/rust-lang/lang-team/issues/66">https://github.com/rust-lang/lang-team/issues/66</a> with just the lint, leaving off the specific details about how to indicate the methods (e.g. <code>#[noop]</code>)</p>



<a name="215136265"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/233931-t-compiler/major%20changes/topic/Add%20a%20%60NOOP_METHOD_CALL%60%20lint%20for%20methods%E2%80%A6%20compiler-team%23375/near/215136265" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aaron Hill <a href="https://rust-lang.github.io/zulip_archive/stream/233931-t-compiler/major-changes/topic/Add.20a.20.60NOOP_METHOD_CALL.60.20lint.20for.20methods.E2.80.A6.20compiler-team.23375.html#215136265">(Oct 30 2020 at 18:53)</a>:</h4>
<p>let me know if I messed up the produce for opening these kinds of issues</p>



<a name="215381445"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/233931-t-compiler/major%20changes/topic/Add%20a%20%60NOOP_METHOD_CALL%60%20lint%20for%20methods%E2%80%A6%20compiler-team%23375/near/215381445" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/233931-t-compiler/major-changes/topic/Add.20a.20.60NOOP_METHOD_CALL.60.20lint.20for.20methods.E2.80.A6.20compiler-team.23375.html#215381445">(Nov 02 2020 at 21:28)</a>:</h4>
<p><span class="user-mention" data-user-id="125294">@Aaron Hill</span> ack, that was the wrong sort of proposal, so I missed it</p>



<a name="215381480"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/233931-t-compiler/major%20changes/topic/Add%20a%20%60NOOP_METHOD_CALL%60%20lint%20for%20methods%E2%80%A6%20compiler-team%23375/near/215381480" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/233931-t-compiler/major-changes/topic/Add.20a.20.60NOOP_METHOD_CALL.60.20lint.20for.20methods.E2.80.A6.20compiler-team.23375.html#215381480">(Nov 02 2020 at 21:28)</a>:</h4>
<p>would you object to closing and re-opening a <a href="https://github.com/rust-lang/lang-team/issues/new?assignees=&amp;labels=major-change%2C+T-lang&amp;template=project_proposal.md&amp;title=%28My+project+proposal%29">project proposal</a>?</p>



<a name="215381491"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/233931-t-compiler/major%20changes/topic/Add%20a%20%60NOOP_METHOD_CALL%60%20lint%20for%20methods%E2%80%A6%20compiler-team%23375/near/215381491" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/233931-t-compiler/major-changes/topic/Add.20a.20.60NOOP_METHOD_CALL.60.20lint.20for.20methods.E2.80.A6.20compiler-team.23375.html#215381491">(Nov 02 2020 at 21:28)</a>:</h4>
<p>should probably reorganize things a bit</p>



<a name="215383742"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/233931-t-compiler/major%20changes/topic/Add%20a%20%60NOOP_METHOD_CALL%60%20lint%20for%20methods%E2%80%A6%20compiler-team%23375/near/215383742" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aaron Hill <a href="https://rust-lang.github.io/zulip_archive/stream/233931-t-compiler/major-changes/topic/Add.20a.20.60NOOP_METHOD_CALL.60.20lint.20for.20methods.E2.80.A6.20compiler-team.23375.html#215383742">(Nov 02 2020 at 21:47)</a>:</h4>
<p>sure</p>



<a name="215383771"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/233931-t-compiler/major%20changes/topic/Add%20a%20%60NOOP_METHOD_CALL%60%20lint%20for%20methods%E2%80%A6%20compiler-team%23375/near/215383771" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aaron Hill <a href="https://rust-lang.github.io/zulip_archive/stream/233931-t-compiler/major-changes/topic/Add.20a.20.60NOOP_METHOD_CALL.60.20lint.20for.20methods.E2.80.A6.20compiler-team.23375.html#215383771">(Nov 02 2020 at 21:48)</a>:</h4>
<p>will there really be a 'project group', though?</p>



<a name="215383839"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/233931-t-compiler/major%20changes/topic/Add%20a%20%60NOOP_METHOD_CALL%60%20lint%20for%20methods%E2%80%A6%20compiler-team%23375/near/215383839" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aaron Hill <a href="https://rust-lang.github.io/zulip_archive/stream/233931-t-compiler/major-changes/topic/Add.20a.20.60NOOP_METHOD_CALL.60.20lint.20for.20methods.E2.80.A6.20compiler-team.23375.html#215383839">(Nov 02 2020 at 21:48)</a>:</h4>
<p>I think this lint will be very similar to <a href="https://github.com/rust-lang/rust/pull/75573">https://github.com/rust-lang/rust/pull/75573</a> in terms of overall complexity</p>



<a name="215383866"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/233931-t-compiler/major%20changes/topic/Add%20a%20%60NOOP_METHOD_CALL%60%20lint%20for%20methods%E2%80%A6%20compiler-team%23375/near/215383866" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aaron Hill <a href="https://rust-lang.github.io/zulip_archive/stream/233931-t-compiler/major-changes/topic/Add.20a.20.60NOOP_METHOD_CALL.60.20lint.20for.20methods.E2.80.A6.20compiler-team.23375.html#215383866">(Nov 02 2020 at 21:48)</a>:</h4>
<p>or have some of the procedurs changed this that PR's FCP?</p>



<a name="215384254"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/233931-t-compiler/major%20changes/topic/Add%20a%20%60NOOP_METHOD_CALL%60%20lint%20for%20methods%E2%80%A6%20compiler-team%23375/near/215384254" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/233931-t-compiler/major-changes/topic/Add.20a.20.60NOOP_METHOD_CALL.60.20lint.20for.20methods.E2.80.A6.20compiler-team.23375.html#215384254">(Nov 02 2020 at 21:52)</a>:</h4>
<p>no there would not be a project group</p>



<a name="215384310"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/233931-t-compiler/major%20changes/topic/Add%20a%20%60NOOP_METHOD_CALL%60%20lint%20for%20methods%E2%80%A6%20compiler-team%23375/near/215384310" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/233931-t-compiler/major-changes/topic/Add.20a.20.60NOOP_METHOD_CALL.60.20lint.20for.20methods.E2.80.A6.20compiler-team.23375.html#215384310">(Nov 02 2020 at 21:52)</a>:</h4>
<p><span class="user-mention" data-user-id="125294">@Aaron Hill</span> that is one of the renamings I want to do :)</p>



<a name="215384328"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/233931-t-compiler/major%20changes/topic/Add%20a%20%60NOOP_METHOD_CALL%60%20lint%20for%20methods%E2%80%A6%20compiler-team%23375/near/215384328" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/233931-t-compiler/major-changes/topic/Add.20a.20.60NOOP_METHOD_CALL.60.20lint.20for.20methods.E2.80.A6.20compiler-team.23375.html#215384328">(Nov 02 2020 at 21:52)</a>:</h4>
<p>the idea is just to propose "projects", often they just end with "go implement it"</p>



<a name="215384357"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/233931-t-compiler/major%20changes/topic/Add%20a%20%60NOOP_METHOD_CALL%60%20lint%20for%20methods%E2%80%A6%20compiler-team%23375/near/215384357" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/233931-t-compiler/major-changes/topic/Add.20a.20.60NOOP_METHOD_CALL.60.20lint.20for.20methods.E2.80.A6.20compiler-team.23375.html#215384357">(Nov 02 2020 at 21:52)</a>:</h4>
<p>only in rare cases do we need to create a whole group, though we can also create a stream if it's useful for design discussion</p>



<a name="215384379"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/233931-t-compiler/major%20changes/topic/Add%20a%20%60NOOP_METHOD_CALL%60%20lint%20for%20methods%E2%80%A6%20compiler-team%23375/near/215384379" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aaron Hill <a href="https://rust-lang.github.io/zulip_archive/stream/233931-t-compiler/major-changes/topic/Add.20a.20.60NOOP_METHOD_CALL.60.20lint.20for.20methods.E2.80.A6.20compiler-team.23375.html#215384379">(Nov 02 2020 at 21:53)</a>:</h4>
<p>sounds good</p>



<a name="215385891"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/233931-t-compiler/major%20changes/topic/Add%20a%20%60NOOP_METHOD_CALL%60%20lint%20for%20methods%E2%80%A6%20compiler-team%23375/near/215385891" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aaron Hill <a href="https://rust-lang.github.io/zulip_archive/stream/233931-t-compiler/major-changes/topic/Add.20a.20.60NOOP_METHOD_CALL.60.20lint.20for.20methods.E2.80.A6.20compiler-team.23375.html#215385891">(Nov 02 2020 at 22:06)</a>:</h4>
<p>Opened <a href="https://github.com/rust-lang/lang-team/issues/67">https://github.com/rust-lang/lang-team/issues/67</a></p>



<a name="220130214"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/233931-t-compiler/major%20changes/topic/Add%20a%20%60NOOP_METHOD_CALL%60%20lint%20for%20methods%E2%80%A6%20compiler-team%23375/near/220130214" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/233931-t-compiler/major-changes/topic/Add.20a.20.60NOOP_METHOD_CALL.60.20lint.20for.20methods.E2.80.A6.20compiler-team.23375.html#220130214">(Dec 16 2020 at 15:33)</a>:</h4>
<p><span class="user-mention" data-user-id="125294">@Aaron Hill</span> are you going to work on the implementation for this? This sounds interesting and I would try to take a stab at it if you're busy with other things.</p>



<a name="220130348"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/233931-t-compiler/major%20changes/topic/Add%20a%20%60NOOP_METHOD_CALL%60%20lint%20for%20methods%E2%80%A6%20compiler-team%23375/near/220130348" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aaron Hill <a href="https://rust-lang.github.io/zulip_archive/stream/233931-t-compiler/major-changes/topic/Add.20a.20.60NOOP_METHOD_CALL.60.20lint.20for.20methods.E2.80.A6.20compiler-team.23375.html#220130348">(Dec 16 2020 at 15:34)</a>:</h4>
<p><span class="user-mention" data-user-id="224872">@Ryan Levick</span> I was planning to, but feel free to work on it!</p>



<a name="223785396"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/233931-t-compiler/major%20changes/topic/Add%20a%20%60NOOP_METHOD_CALL%60%20lint%20for%20methods%E2%80%A6%20compiler-team%23375/near/223785396" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> triagebot <a href="https://rust-lang.github.io/zulip_archive/stream/233931-t-compiler/major-changes/topic/Add.20a.20.60NOOP_METHOD_CALL.60.20lint.20for.20methods.E2.80.A6.20compiler-team.23375.html#223785396">(Jan 23 2021 at 23:58)</a>:</h4>
<p><span class="user-group-mention" data-user-group-id="492">@T-compiler</span>: Proposal <a href="https://github.com/rust-lang/compiler-team/issues/375#issuecomment-766236043">#375</a> has been seconded, and will be approved in 10 days if no objections are raised.</p>



<a name="223885191"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/233931-t-compiler/major%20changes/topic/Add%20a%20%60NOOP_METHOD_CALL%60%20lint%20for%20methods%E2%80%A6%20compiler-team%23375/near/223885191" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/233931-t-compiler/major-changes/topic/Add.20a.20.60NOOP_METHOD_CALL.60.20lint.20for.20methods.E2.80.A6.20compiler-team.23375.html#223885191">(Jan 25 2021 at 11:46)</a>:</h4>
<p>The implementation for this can be found here: <a href="https://github.com/rust-lang/rust/pull/80723">https://github.com/rust-lang/rust/pull/80723</a></p>



<a name="225187828"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/233931-t-compiler/major%20changes/topic/Add%20a%20%60NOOP_METHOD_CALL%60%20lint%20for%20methods%E2%80%A6%20compiler-team%23375/near/225187828" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> triagebot <a href="https://rust-lang.github.io/zulip_archive/stream/233931-t-compiler/major-changes/topic/Add.20a.20.60NOOP_METHOD_CALL.60.20lint.20for.20methods.E2.80.A6.20compiler-team.23375.html#225187828">(Feb 04 2021 at 16:50)</a>:</h4>
<p>This proposal has been accepted: <a href="https://github.com/rust-lang/compiler-team/issues/375">#375</a>.</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>